[libc-commits] [PATCH] D147375: [libc] Use string_view for write_to_stderr

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Sat Apr 1 04:36:07 PDT 2023


gchatelet created this revision.
gchatelet added reviewers: sivachandra, jhuber6.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
gchatelet requested review of this revision.

This patch makes use of `cpp::string_view` instead of `const char*` for `write_to_stderr`. This helps sending non null-terminated buffers such as a single character, `cpp::string_view` or `cpp::string`.
It also fizes the gpu version that had several bugs (See https://reviews.llvm.org/D145913#4236641).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147375

Files:
  libc/src/__support/OSUtil/gpu/CMakeLists.txt
  libc/src/__support/OSUtil/gpu/io.cpp
  libc/src/__support/OSUtil/gpu/io.h
  libc/src/__support/OSUtil/linux/CMakeLists.txt
  libc/src/__support/OSUtil/linux/io.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147375.510211.patch
Type: text/x-patch
Size: 4221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230401/675befb4/attachment.bin>


More information about the libc-commits mailing list