[libc-commits] [PATCH] D134994: [libc] disable syscall test without fullbuild

[Michael Jones via Phabricator via libc-commits]

michaelrj created this revision.
michaelrj added reviewers: sivachandra, lntue.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
michaelrj requested review of this revision.

Our syscall implementation depends on a specific macro that's only
defined in our headers. If we're not using our headers, then the test
doesn't work. I've disabled the test in this case because there's no
point in testing the system libc's syscall implementation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134994

Files:
  libc/test/src/unistd/CMakeLists.txt


Index: libc/test/src/unistd/CMakeLists.txt
===================================================================
--- libc/test/src/unistd/CMakeLists.txt
+++ libc/test/src/unistd/CMakeLists.txt
@@ -362,17 +362,19 @@
     libc.src.unistd.geteuid
 )
 
-add_libc_unittest(
-  syscall_test
-  SUITE
-    libc_unistd_unittests
-  SRCS
-    syscall_test.cpp
-  DEPENDS
-    libc.src.unistd.__llvm_libc_syscall
-    libc.include.errno
-    libc.include.unistd
-    libc.include.fcntl
-    libc.include.sys_syscall
-    libc.test.errno_setter_matcher
-)
+if(LLVM_LIBC_FULL_BUILD)
+  add_libc_unittest(
+    syscall_test
+    SUITE
+      libc_unistd_unittests
+    SRCS
+      syscall_test.cpp
+    DEPENDS
+      libc.src.unistd.__llvm_libc_syscall
+      libc.include.errno
+      libc.include.unistd
+      libc.include.fcntl
+      libc.include.sys_syscall
+      libc.test.errno_setter_matcher
+  )
+endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134994.464422.patch
Type: text/x-patch
Size: 902 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220930/2e43499d/attachment.bin>