[libc-commits] [PATCH] D134676: [libc][windows] fix small build issues.
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Sep 26 16:06:38 PDT 2022
sivachandra added inline comments.
================
Comment at: libc/src/CMakeLists.txt:12
-if(${LIBC_TARGET_OS} STREQUAL "linux")
+if((${LIBC_TARGET_OS} STREQUAL "linux") OR (${LIBC_TARGET_OS} STREQUAL "windows"))
add_subdirectory(dirent)
----------------
I think this is a case of inappropriate design somewhere - adding these directories for Windows incorrectly implies that they are available for Windows as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134676/new/
https://reviews.llvm.org/D134676
More information about the libc-commits
mailing list