[libc-commits] [PATCH] D134498: [libc] add madvise and posix_madvise

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/sys/mman/linux/posix_madvise.cpp:29
+
+  return -ret_val;
+}
----------------
To be safe, may be we should:

```
return ret_val < 0 ? -ret_val : 0;
```


================
Comment at: libc/test/src/sys/mman/linux/posix_madvise_test.cpp:49
+  // value is actually the error code.
+  EXPECT_THAT(__llvm_libc::posix_madvise(nullptr, 8, POSIX_MADV_SEQUENTIAL),
+              Succeeds(ENOMEM));
----------------
Since `errno` not affected, we should use `EXPECT_EQ`. Here and everywhere above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134498/new/

https://reviews.llvm.org/D134498