[libc-commits] [PATCH] D131023: [libc] add printf decimal float conversion

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/src/stdio/printf_core/float_dec_converter.h:1
+//===-- Decimal Float Converter for printf ----------------------*- C++ -*-===//
+//
----------------
sivachandra wrote:
> sivachandra wrote:
> > Why should this live entirely in a header file?
> Is this answered somewhere?
Right now it's mostly to enable the use of the `converter_atlas` to replace the implementations of these conversion functions, although  there isn't a particular reason beyond that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131023/new/

https://reviews.llvm.org/D131023