[libc-commits] [PATCH] D133890: [CMake] Do these replacements to make use of D132608
Saleem Abdulrasool via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Sep 19 10:58:21 PDT 2022
compnerd added a comment.
I don't see anything wrong with this change per se, but I'm conflicted on the name of the variable. These are not standard variables but are encroaching on the CMake namespace. What happens if upstream decides to use these names? I think that we should keep the names in the `LLVM_` namespace. However, I realize that the variable itself is not being touched here and this is a mechanical replacement.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits