[libc-commits] [PATCH] D133550: [libc][math] Implement acosf function correctly rounded for all rounding modes.

[Kirill Okhotnikov via Phabricator via libc-commits]

orex accepted this revision.
orex added inline comments.


================
Comment at: libc/src/math/generic/asinf.cpp:17
 
 #include <errno.h>
 
----------------
Please delete this. It is not needed here. My fault.


================
Comment at: libc/src/math/generic/inv_trigf_utils.h:95
+//                 [|1, D...|], [0, 0.5]);
+constexpr double ASIN_COEFFS[10] = {0x1.5555555540fa1p-3, 0x1.333333512edc2p-4,
+                                    0x1.6db6cc1541b31p-5, 0x1.f1caff324770ep-6,
----------------
Don't you think that it is better to put this array to cpp file?


================
Comment at: libc/test/src/math/exhaustive/acosf_test.cpp:38
 
 // Range: [0, Inf];
 static const uint32_t POS_START = 0x0000'0000U;
----------------
Do you really need this test until inf? Out of range values can be covered by unittests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133550/new/

https://reviews.llvm.org/D133550