[libc-commits] [PATCH] D133163: [libc] add ErrorAnd class to strtointeger

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Sep 1 15:52:53 PDT 2022


lntue added inline comments.


================
Comment at: libc/src/__support/error_and.h:24
+// able to remove the error code if the result is discarded.
+template <typename T> class ErrorAnd {
+  T return_val;
----------------
I think `ValWithErrno`, `WithErrno` or something similar would be more suitable, especially since the constructors have `value` comes first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133163/new/

https://reviews.llvm.org/D133163



More information about the libc-commits mailing list