[libc-commits] [libc] 45233cc - [libc][math] Add place-holder implementation for pow function.
Tue Ly via libc-commits
libc-commits at lists.llvm.org
Mon Oct 31 14:23:41 PDT 2022
Author: Tue Ly
Date: 2022-10-31T17:23:33-04:00
New Revision: 45233cc1ca26c2fb6eeddd9007c7bac2731557bd
URL: https://github.com/llvm/llvm-project/commit/45233cc1ca26c2fb6eeddd9007c7bac2731557bd
DIFF: https://github.com/llvm/llvm-project/commit/45233cc1ca26c2fb6eeddd9007c7bac2731557bd.diff
LOG: [libc][math] Add place-holder implementation for pow function.
Add place-holder implementation for pow function to unblock libc demo
examples.
Reviewed By: michaelrj
Differential Revision: https://reviews.llvm.org/D137109
Added:
libc/src/math/generic/pow.cpp
libc/src/math/pow.h
libc/test/src/math/pow_test.cpp
Modified:
libc/config/linux/aarch64/entrypoints.txt
libc/config/linux/x86_64/entrypoints.txt
libc/config/windows/entrypoints.txt
libc/spec/stdc.td
libc/src/math/CMakeLists.txt
libc/src/math/generic/CMakeLists.txt
libc/test/src/math/CMakeLists.txt
Removed:
################################################################################
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 440bc2be96fa8..4accc1443b49d 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -280,6 +280,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nextafter
libc.src.math.nextafterf
libc.src.math.nextafterl
+ libc.src.math.pow
libc.src.math.remainderf
libc.src.math.remainder
libc.src.math.remainderl
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index cef4e26b16778..b8d962dc7e2a2 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -282,6 +282,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nextafter
libc.src.math.nextafterf
libc.src.math.nextafterl
+ libc.src.math.pow
libc.src.math.remainderf
libc.src.math.remainder
libc.src.math.remainderl
diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt
index d50927ec3c4a1..69a0acab6ad5f 100644
--- a/libc/config/windows/entrypoints.txt
+++ b/libc/config/windows/entrypoints.txt
@@ -182,6 +182,7 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.math.nextafter
libc.src.math.nextafterf
libc.src.math.nextafterl
+ libc.src.math.pow
libc.src.math.remainderf
libc.src.math.remainder
libc.src.math.remainderl
diff --git a/libc/spec/stdc.td b/libc/spec/stdc.td
index 22e233c5faa9f..1c0d7c2dd8d99 100644
--- a/libc/spec/stdc.td
+++ b/libc/spec/stdc.td
@@ -477,6 +477,8 @@ def StdC : StandardSpec<"stdc"> {
FunctionSpec<"nextafter", RetValSpec<DoubleType>, [ArgSpec<DoubleType>, ArgSpec<DoubleType>]>,
FunctionSpec<"nextafterl", RetValSpec<LongDoubleType>, [ArgSpec<LongDoubleType>, ArgSpec<LongDoubleType>]>,
+ FunctionSpec<"pow", RetValSpec<DoubleType>, [ArgSpec<DoubleType>, ArgSpec<DoubleType>]>,
+
FunctionSpec<"coshf", RetValSpec<FloatType>, [ArgSpec<FloatType>]>,
FunctionSpec<"sinhf", RetValSpec<FloatType>, [ArgSpec<FloatType>]>,
FunctionSpec<"tanhf", RetValSpec<FloatType>, [ArgSpec<FloatType>]>,
diff --git a/libc/src/math/CMakeLists.txt b/libc/src/math/CMakeLists.txt
index 0c425c7658fd8..cd0985a40cac9 100644
--- a/libc/src/math/CMakeLists.txt
+++ b/libc/src/math/CMakeLists.txt
@@ -171,6 +171,8 @@ add_math_entrypoint_object(nextafter)
add_math_entrypoint_object(nextafterf)
add_math_entrypoint_object(nextafterl)
+add_math_entrypoint_object(pow)
+
add_math_entrypoint_object(remainder)
add_math_entrypoint_object(remainderf)
add_math_entrypoint_object(remainderl)
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 50617598de172..21f993c9c72ba 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -1368,3 +1368,15 @@ add_entrypoint_object(
-O3
)
+add_entrypoint_object(
+ pow
+ SRCS
+ pow.cpp
+ HDRS
+ ../pow.h
+ DEPENDS
+ .expf
+ .logf
+ COMPILE_OPTIONS
+ -O3
+)
diff --git a/libc/src/math/generic/pow.cpp b/libc/src/math/generic/pow.cpp
new file mode 100644
index 0000000000000..77f866842e691
--- /dev/null
+++ b/libc/src/math/generic/pow.cpp
@@ -0,0 +1,24 @@
+//===-- Implementation of pow function ------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/math/pow.h"
+#include "src/math/expf.h"
+#include "src/math/logf.h"
+
+#include "src/__support/common.h"
+
+namespace __llvm_libc {
+
+LLVM_LIBC_FUNCTION(double, pow, (double x, double y)) {
+ // Place-holder implementation for double precision pow function.
+ // TODO: Implement correctly rounded pow function for double precision.
+ return static_cast<double>(
+ expf(static_cast<float>(y) * logf(static_cast<float>(x))));
+}
+
+} // namespace __llvm_libc
diff --git a/libc/src/math/pow.h b/libc/src/math/pow.h
new file mode 100644
index 0000000000000..26fed175787a9
--- /dev/null
+++ b/libc/src/math/pow.h
@@ -0,0 +1,18 @@
+//===-- Implementation header for pow ---------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_MATH_POW_H
+#define LLVM_LIBC_SRC_MATH_POW_H
+
+namespace __llvm_libc {
+
+double pow(double x, double y);
+
+} // namespace __llvm_libc
+
+#endif // LLVM_LIBC_SRC_MATH_POW_H
diff --git a/libc/test/src/math/CMakeLists.txt b/libc/test/src/math/CMakeLists.txt
index c285c35397cfa..68adecbee324b 100644
--- a/libc/test/src/math/CMakeLists.txt
+++ b/libc/test/src/math/CMakeLists.txt
@@ -1521,6 +1521,19 @@ add_fp_unittest(
libc.src.__support.FPUtil.fp_bits
)
+add_fp_unittest(
+ pow_test
+ NEED_MPFR
+ SUITE
+ libc_math_unittests
+ SRCS
+ pow_test.cpp
+ DEPENDS
+ libc.include.errno
+ libc.src.errno.errno
+ libc.src.math.pow
+)
+
add_subdirectory(generic)
add_subdirectory(exhaustive)
add_subdirectory(
diff erential_testing)
diff --git a/libc/test/src/math/pow_test.cpp b/libc/test/src/math/pow_test.cpp
new file mode 100644
index 0000000000000..effade0bc3888
--- /dev/null
+++ b/libc/test/src/math/pow_test.cpp
@@ -0,0 +1,37 @@
+//===-- Unittests for pow -------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/math/pow.h"
+#include "utils/MPFRWrapper/MPFRUtils.h"
+#include "utils/UnitTest/FPMatcher.h"
+#include "utils/UnitTest/Test.h"
+#include <math.h>
+
+#include <errno.h>
+#include <stdint.h>
+
+using FPBits = __llvm_libc::fputil::FPBits<double>;
+
+namespace mpfr = __llvm_libc::testing::mpfr;
+
+DECLARE_SPECIAL_CONSTANTS(double)
+
+TEST(LlvmLibcAsinTest, SpecialNumbers) {
+ errno = 0;
+
+ EXPECT_FP_EQ(aNaN, __llvm_libc::pow(aNaN, aNaN));
+ EXPECT_MATH_ERRNO(0);
+
+ EXPECT_FP_EQ(1.0, __llvm_libc::pow(1.0, 1.0));
+ EXPECT_MATH_ERRNO(0);
+
+ EXPECT_FP_EQ(1.0, __llvm_libc::pow(1.0, 2.0));
+ EXPECT_MATH_ERRNO(0);
+
+ EXPECT_FP_EQ(inf, __llvm_libc::pow(2.0, inf));
+}
More information about the libc-commits
mailing list