[libc-commits] [PATCH] D136865: [libc] Improve testing of mem functions

[Clement Courbet via Phabricator via libc-commits]

courbet added inline comments.


================
Comment at: libc/test/src/string/bcmp_test.cpp:45
+
+TEST(LlvmLibcBcmpTest, Thorough) {
+  static constexpr size_t kSize = 1024;
----------------
`SizeSweep` or `AllSizes` would be clearer IMO (here and below).


================
Comment at: libc/test/src/string/bcmp_test.cpp:46
+TEST(LlvmLibcBcmpTest, Thorough) {
+  static constexpr size_t kSize = 1024;
+  static constexpr auto Impl = CmpAdaptor<__llvm_libc::bcmp>;
----------------
`kMaxSize` (here and below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136865/new/

https://reviews.llvm.org/D136865