[libc-commits] [PATCH] D136799: [libc] Implement a high-precision floating point class.

Kirill Okhotnikov via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Oct 28 00:38:31 PDT 2022


orex added inline comments.


================
Comment at: libc/src/__support/FPUtil/big_float.h:120
+template <size_t LENGTH>
+constexpr inline pair<BigFloat<LENGTH / 2>> split(const BigFloat<LENGTH> &a) {
+  constexpr size_t SHIFT_LENGTH = LENGTH / 2;
----------------
orex wrote:
> I'm not an expert in C++ standard, but pair with one template argument looks suspicious for me. Does C++ standard saying how it should be expanded? 
The comment is not valid. Sorry.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136799/new/

https://reviews.llvm.org/D136799



More information about the libc-commits mailing list