[libc-commits] [PATCH] D136881: [libc] add features to bitset
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Thu Oct 27 13:47:28 PDT 2022
sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.
Please add unit-tests for the new methods.
================
Comment at: libc/src/__support/CPP/bitset.h:35
+ // true. It assumes that Start < End.
+ constexpr void set_range(size_t Start, size_t End) {
+ size_t start_index = Start / BITS_PER_UNIT;
----------------
This method is not in `std::bitset` so we should not include it here. You can define a helper function in the other patch with the same functionality.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136881/new/
https://reviews.llvm.org/D136881
More information about the libc-commits
mailing list