[libc-commits] [PATCH] D136802: [libc] add locale free strcoll

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/test/src/string/strcoll_test.cpp:22
+  result = __llvm_libc::strcoll(s2, s1);
+  ASSERT_EQ(result, 0);
+}
----------------
sivachandra wrote:
> For completeness, you should add `ASSERT_GT` and `ASSERT_LT` tests also.
I'm avoiding adding GT and LT tests because they'll likely be wrong in some locales. Until we have a system for setting the locale per-test, similar to what we have for floating point rounding modes, any inequality comparison is unsafe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136802/new/

https://reviews.llvm.org/D136802