[libc-commits] [PATCH] D135134: [libc] New version of the mem* framework

Fri Oct 14 07:53:21 PDT 2022

gchatelet added a comment.

In D135134#3858483 <https://reviews.llvm.org/D135134#3858483>, @rupprecht wrote:

> Why does this keep getting reverted and relanded? There is nothing in the commit description besides the default one from git, can you please include one? https://llvm.org/docs/GettingStarted.html#reverting-a-change

Thx for pointing me to the doc. I was unaware of this process.
Also my apologies here for the noise. Admittedly this is painful for everyone in CC 🙇

I initially thought I could fix the bug easily but there were different ones that I couldn't get to see because I don't have the hardware nor presubmit bots to catch these errors before submitting.
FTR errors were:

- missing include for aarch64
- off by one error in the implementation of memmove for embedded devices (ARM32)
- warning as error for unused functions breaking the build for certain configurations
- typos for embedded versions of bcmp anc memcmp.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135134/new/

https://reviews.llvm.org/D135134