[libc-commits] [PATCH] D135731: [libc] add headers sys/auxv sys/prctl and sys/time

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Oct 12 13:19:38 PDT 2022


michaelrj added inline comments.


================
Comment at: libc/include/llvm-libc-macros/linux/sys-time-macros.h:55
+// shifts sec left by 1) but those should be rare.
+#define timercmp(timeval_ptr_a, timeval_ptr_b, CMP)                            \
+  ((((timeval_ptr_a)->tv_sec CMP(timeval_ptr_b)->tv_sec) ==                    \
----------------
sivachandra wrote:
> What problem is this complication solving?
I misread the man page and thought that the simpler implementation didn't work in certain circumstances. I've fixed it now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135731/new/

https://reviews.llvm.org/D135731



More information about the libc-commits mailing list