[libc-commits] [PATCH] D135134: [libc] New version of the mem* framework

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Oct 7 02:30:54 PDT 2022


gchatelet marked 2 inline comments as done.
gchatelet added inline comments.


================
Comment at: libc/src/string/memory_utils/memcmp_implementations.h:124
+  align_to_next_boundary<32, Arg::P1>(p1, p2, count);
+  return x86::avx2::Memcmp<32>::loop_and_tail(p1, p2, count);
+}
----------------
courbet wrote:
> can you comment on why `32` here ?
The implementations here are not final, I need to benchmark them thoroughly before pushing the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135134/new/

https://reviews.llvm.org/D135134



More information about the libc-commits mailing list