[libc-commits] [PATCH] D135134: [libc] New version of the mem* framework

[Clement Courbet via Phabricator via libc-commits]

courbet added inline comments.


================
Comment at: libc/src/string/memory_utils/op_generic.h:353-359
+  // e.g. Moving two bytes and making sure dst is then aligned.
+  // [  |       |       |       |      ]
+  // [____XXXXXXXXXXXXXXXXXXXXXXXXXXXX_]
+  // [____LLLLLLLL_____________________]
+  // [______LLLLLLLL___________________]
+  // [_SSSSSSSS________________________]
+  // [___SSSSSSSS______________________]
----------------
not sure why there are two diagrams (here and below)


================
Comment at: libc/src/string/memory_utils/utils.h:127
+
+using MemcmpType = StrictIntegralType<int32_t>;
+using BcmpType = StrictIntegralType<uint32_t>;
----------------
`MemCmpResultType`, or `MemCmpReturnType`. (I would expect the type of the symbol to be "pointer to function").


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135134/new/

https://reviews.llvm.org/D135134