[libc-commits] [PATCH] D135179: [libc] add CPU_COUNT macro and backing function

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Oct 4 14:08:58 PDT 2022


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/spec/gnu_ext.td:55
+            [ArgSpec<SizeTType>, ArgSpec<ConstCpuSetPtr>]
+        >,
       ]
----------------
michaelrj wrote:
> sivachandra wrote:
> > This should go into https://github.com/llvm/llvm-project/blob/main/libc/spec/llvm_libc_ext.td. Also, the function is really an internal function - it's name should have the `__` prefix.
> in that case I should probably also move `__llvm_libc_syscall` into `llvm_libc_ext.td` in a followup patch.
Yes, I missed that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135179/new/

https://reviews.llvm.org/D135179



More information about the libc-commits mailing list