[libc-commits] [PATCH] D135134: [libc] New version of the framework

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Oct 4 01:56:11 PDT 2022


gchatelet created this revision.
gchatelet added a reviewer: courbet.
Herald added subscribers: libc-commits, ecnelises, tschuett, pengfei, kristof.beyls.
Herald added projects: libc-project, All.
gchatelet requested review of this revision.

This version is more composable and also simpler at the expense of being more explicit and more verbose.
This patch is not meant to be submitted but gives an idea of the change.
Codegen can be checked in https://godbolt.org/z/6z1dEoWbs by removing the "static inline" before individual functions.

Unittests are coming.

Suggested review order:

- utils
- op_base
- op_builtin
- op_generic
- op_x86 / op_aarch64
- *_implementations.h


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135134

Files:
  libc/src/stdio/printf_core/string_writer.cpp
  libc/src/string/memmove.cpp
  libc/src/string/memory_utils/CMakeLists.txt
  libc/src/string/memory_utils/bcmp_implementations.h
  libc/src/string/memory_utils/elements.h
  libc/src/string/memory_utils/elements_aarch64.h
  libc/src/string/memory_utils/elements_x86.h
  libc/src/string/memory_utils/memcmp_implementations.h
  libc/src/string/memory_utils/memcpy_implementations.h
  libc/src/string/memory_utils/memset_implementations.h
  libc/src/string/memory_utils/op_aarch64.h
  libc/src/string/memory_utils/op_base.h
  libc/src/string/memory_utils/op_builtin.h
  libc/src/string/memory_utils/op_generic.h
  libc/src/string/memory_utils/op_x86.h
  libc/src/string/memory_utils/utils.h
  libc/src/string/memset.cpp
  libc/test/src/string/bcmp_test.cpp
  libc/test/src/string/memmove_test.cpp
  libc/test/src/string/memory_utils/CMakeLists.txt
  libc/test/src/string/memory_utils/elements_test.cpp
  libc/test/src/string/memory_utils/memory_access_test.cpp
  libc/test/src/string/memory_utils/utils_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135134.464920.patch
Type: text/x-patch
Size: 128442 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20221004/75a6d5eb/attachment-0001.bin>


More information about the libc-commits mailing list