[libc-commits] [PATCH] D135134: [libc] New version of the mem* framework

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Oct 4 08:03:01 PDT 2022


gchatelet marked 4 inline comments as done.
gchatelet added inline comments.


================
Comment at: libc/src/string/memory_utils/utils.h:90
+
 // Returns the offset from `ptr` to the next cache line.
 static inline intptr_t offset_to_next_cache_line(const void *ptr) {
----------------
courbet wrote:
> This terminology is not consistent to what's above. It should be `offset_to_cacheline_up` or something like this. Also it would not hurt to comment the behaviour explicitly.
It is unused, I've removed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135134/new/

https://reviews.llvm.org/D135134



More information about the libc-commits mailing list