[libc-commits] [PATCH] D135131: [libc] Add a minimal implementation of the POSIX fork function.

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/include/llvm-libc-macros/linux/sys-wait-macros.h:13
+// Wait status info macros
+#define WTERMSIG(status) ((status & 0x7F))
+#define WIFEXITED(status) (WTERMSIG(status) == 0)
----------------
`((status) & 0x7F)` instead.


================
Comment at: libc/src/unistd/linux/fork.cpp:24
+LLVM_LIBC_FUNCTION(int, fork, (void)) {
+#ifdef SYS_clone
+  long ret = __llvm_libc::syscall_impl(SYS_fork);
----------------
`SYS_fork`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135131/new/

https://reviews.llvm.org/D135131