[libc-commits] [PATCH] D135134: [libc] New version of the mem* framework

[Clement Courbet via Phabricator via libc-commits]

courbet added inline comments.


================
Comment at: libc/src/string/memory_utils/op_base.h:8
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_STRING_MEMORY_UTILS_OP_BASE_H
----------------
A file comment would help.


================
Comment at: libc/src/string/memory_utils/op_base.h:23
+
+template <typename T>
+static inline void memcpy_tail(Ptr __restrict dst, CPtr __restrict src,
----------------
It would be nice to define some terminology and have a better name for `T`, maybe `Op` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135134/new/

https://reviews.llvm.org/D135134