[libc-commits] [PATCH] D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Oct 3 21:34:53 PDT 2022


lntue added inline comments.


================
Comment at: libc/src/__support/FPUtil/FPBits.h:174
+  static constexpr T build_quiet_nan(UIntType v) {
+    return build_quiet_nan(FloatProp::QUIET_NAN_MASK | v);
+  }
----------------
I think you meant to call `build_nan`.  Otherwise this is an infinite recursion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134917/new/

https://reviews.llvm.org/D134917



More information about the libc-commits mailing list