[libc-commits] [PATCH] D129808: [libc] add unsafe mode to strlen

Nick Desaulniers via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Nov 28 13:20:21 PST 2022


nickdesaulniers added a comment.

In D129808#3660990 <https://reviews.llvm.org/D129808#3660990>, @michaelrj wrote:

> change from using FLAGS to using a full cmake option. Currently it defaults to off, so if we want to test this on the bots then we'll either need to change the default or adjust the cmake command the bots use.

IIRC, @michaelrj and I had a discussion about how this relates to sanitizers.  For `LIBC_FAST_UNSAFE_STRLEN` could this be the default unless an existing cmake flag is used to build llvm-libc sanitized? (I assume there's an existing cmake flag for denoting that I would like a build of llvm-libc instrumented with *SAN?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129808/new/

https://reviews.llvm.org/D129808



More information about the libc-commits mailing list