[libc-commits] [PATCH] D138239: [libc][math] Remove UInt<128>::operation* specialization.

[Tue Ly via Phabricator via libc-commits]

lntue created this revision.
lntue added reviewers: michaelrj, sivachandra.
Herald added subscribers: ecnelises, tschuett.
Herald added projects: libc-project, All.
lntue requested review of this revision.

Remove UInt<128>::operation* specialization since the generic implementation
works well enough:


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138239

Files:
  libc/src/__support/UInt.h


Index: libc/src/__support/UInt.h
===================================================================
--- libc/src/__support/UInt.h
+++ libc/src/__support/UInt.h
@@ -495,40 +495,6 @@
   const uint64_t *data() const { return val; }
 };
 
-template <>
-constexpr UInt<128> UInt<128>::operator*(const UInt<128> &other) const {
-  // temp low covers bits 0-63, middle covers 32-95, high covers 64-127, and
-  // high overflow covers 96-159.
-  uint64_t temp_low = low(val[0]) * low(other[0]);
-  uint64_t temp_middle_1 = low(val[0]) * high(other[0]);
-  uint64_t temp_middle_2 = high(val[0]) * low(other[0]);
-
-  // temp_middle is split out so that overflows can be handled, but since
-  // but since the result will be truncated to 128 bits any overflow from here
-  // on doesn't matter.
-  uint64_t temp_high = low(val[0]) * low(other[1]) +
-                       high(val[0]) * high(other[0]) +
-                       low(val[1]) * low(other[0]);
-
-  uint64_t temp_high_overflow =
-      low(val[0]) * high(other[1]) + high(val[0]) * low(other[1]) +
-      low(val[1]) * high(other[0]) + high(val[1]) * low(other[0]);
-
-  // temp_low_middle has just the high 32 bits of low, as well as any
-  // overflow.
-  uint64_t temp_low_middle =
-      high(temp_low) + low(temp_middle_1) + low(temp_middle_2);
-
-  uint64_t new_low = low(temp_low) + (low(temp_low_middle) << 32);
-  uint64_t new_high = high(temp_low_middle) + high(temp_middle_1) +
-                      high(temp_middle_2) + temp_high +
-                      (low(temp_high_overflow) << 32);
-  UInt<128> result(0);
-  result[0] = new_low;
-  result[1] = new_high;
-  return result;
-}
-
 // Provides limits of UInt<128>.
 template <> class numeric_limits<UInt<128>> {
 public:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138239.476245.patch
Type: text/x-patch
Size: 1743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20221117/b41ddc49/attachment.bin>