[libc-commits] [PATCH] D138111: [libc][benchmark] Fix wrong BatchSize leading to data not fitting in L1.

Clement Courbet via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Nov 16 04:40:34 PST 2022


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/benchmarks/LibcMemoryBenchmark.cpp:92
+  if (ParameterBytes + BufferBytes + L1LeftAsideBytes > getL1DataCacheSize())
+    report_fatal_error("Invalid state");
 }
----------------
The error message is not very useful. Maybe something along the lines of:

`We're splitting a buffer of the size of the L1 cache between a data buffer and a benchmark parameters buffer, so by construction the total shoul dnot exceed the size of the L1 cache`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138111/new/

https://reviews.llvm.org/D138111



More information about the libc-commits mailing list