[libc-commits] [PATCH] D138061: [libc] disable flakey tests

[Michael Jones via Phabricator via libc-commits]

michaelrj updated this revision to Diff 475599.
michaelrj added a comment.

remove gettimeofday changes since a proper fix was landed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138061/new/

https://reviews.llvm.org/D138061

Files:
  libc/test/src/sys/mman/linux/mprotect_test.cpp


Index: libc/test/src/sys/mman/linux/mprotect_test.cpp
===================================================================
--- libc/test/src/sys/mman/linux/mprotect_test.cpp
+++ libc/test/src/sys/mman/linux/mprotect_test.cpp
@@ -43,6 +43,9 @@
   EXPECT_THAT(__llvm_libc::munmap(addr, alloc_size), Succeeds());
 }
 
+// This test is disabled currently due to flakeyness. It will be re-enabled once
+// it is less flakey.
+/*
 TEST(LlvmLibcMProtectTest, Error_InvalidWrite) {
   // attempting to write to a read-only protected part of memory should cause a
   // segfault.
@@ -60,3 +63,4 @@
   // Reading from a write only segment may succeed on some platforms, so there's
   // no test to check that.
 }
+*/


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138061.475599.patch
Type: text/x-patch
Size: 706 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20221115/d8232e71/attachment.bin>