[libc-commits] [PATCH] D138056: [libc] re-enable assert
Michael Jones via Phabricator via libc-commits
libc-commits at lists.llvm.org
Tue Nov 15 13:38:56 PST 2022
michaelrj updated this revision to Diff 475566.
michaelrj marked an inline comment as done.
michaelrj added a comment.
remove extraneous comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138056/new/
https://reviews.llvm.org/D138056
Files:
libc/config/linux/x86_64/entrypoints.txt
libc/spec/llvm_libc_ext.td
libc/src/CMakeLists.txt
libc/test/src/CMakeLists.txt
Index: libc/test/src/CMakeLists.txt
===================================================================
--- libc/test/src/CMakeLists.txt
+++ libc/test/src/CMakeLists.txt
@@ -49,9 +49,7 @@
endif()
add_subdirectory(dirent)
-# The signal API is currently disabled as signal.h is incorrect.
-# since assert uses the signal API, we disable assert also.
-# add_subdirectory(assert)
+add_subdirectory(assert)
add_subdirectory(setjmp)
add_subdirectory(signal)
add_subdirectory(spawn)
Index: libc/src/CMakeLists.txt
===================================================================
--- libc/src/CMakeLists.txt
+++ libc/src/CMakeLists.txt
@@ -23,9 +23,7 @@
return()
endif()
-# The signal API is currently disabled as signal.h is incorrect.
-# since assert uses the signal API, we disable assert also.
-# add_subdirectory(assert)
+add_subdirectory(assert)
add_subdirectory(setjmp)
add_subdirectory(signal)
add_subdirectory(spawn)
Index: libc/spec/llvm_libc_ext.td
===================================================================
--- libc/spec/llvm_libc_ext.td
+++ libc/spec/llvm_libc_ext.td
@@ -28,7 +28,6 @@
"__assert_fail",
RetValSpec<NoReturn>,
[ArgSpec<ConstCharPtr>, ArgSpec<ConstCharPtr>, ArgSpec<UnsignedType>, ArgSpec<ConstCharPtr>]
-
>,
]
>;
Index: libc/config/linux/x86_64/entrypoints.txt
===================================================================
--- libc/config/linux/x86_64/entrypoints.txt
+++ libc/config/linux/x86_64/entrypoints.txt
@@ -313,7 +313,7 @@
if(LLVM_LIBC_FULL_BUILD)
list(APPEND TARGET_LIBC_ENTRYPOINTS
# assert.h entrypoints
- # libc.src.assert.__assert_fail
+ libc.src.assert.__assert_fail
# dirent.h entrypoints
libc.src.dirent.closedir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138056.475566.patch
Type: text/x-patch
Size: 1778 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20221115/1781610c/attachment-0001.bin>
More information about the libc-commits
mailing list