[libc-commits] [PATCH] D138056: [libc] re-enable assert

[Michael Jones via Phabricator via libc-commits]

michaelrj created this revision.
michaelrj added reviewers: sivachandra, lntue.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
michaelrj requested review of this revision.

The assert functions were disabled while the signal functions were being
fixed. This patch re-enables them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138056

Files:
  libc/config/linux/x86_64/entrypoints.txt
  libc/spec/llvm_libc_ext.td
  libc/src/CMakeLists.txt
  libc/test/src/CMakeLists.txt


Index: libc/test/src/CMakeLists.txt
===================================================================
--- libc/test/src/CMakeLists.txt
+++ libc/test/src/CMakeLists.txt
@@ -51,7 +51,7 @@
 add_subdirectory(dirent)
 # The signal API is currently disabled as signal.h is incorrect.
 # since assert uses the signal API, we disable assert also.
-# add_subdirectory(assert)
+add_subdirectory(assert)
 add_subdirectory(setjmp)
 add_subdirectory(signal)
 add_subdirectory(spawn)
Index: libc/src/CMakeLists.txt
===================================================================
--- libc/src/CMakeLists.txt
+++ libc/src/CMakeLists.txt
@@ -23,9 +23,7 @@
   return()
 endif()
 
-# The signal API is currently disabled as signal.h is incorrect.
-# since assert uses the signal API, we disable assert also.
-# add_subdirectory(assert)
+add_subdirectory(assert)
 add_subdirectory(setjmp)
 add_subdirectory(signal)
 add_subdirectory(spawn)
Index: libc/spec/llvm_libc_ext.td
===================================================================
--- libc/spec/llvm_libc_ext.td
+++ libc/spec/llvm_libc_ext.td
@@ -28,7 +28,6 @@
               "__assert_fail",
               RetValSpec<NoReturn>,
               [ArgSpec<ConstCharPtr>, ArgSpec<ConstCharPtr>, ArgSpec<UnsignedType>, ArgSpec<ConstCharPtr>]
-
           >,
       ]
   >;
Index: libc/config/linux/x86_64/entrypoints.txt
===================================================================
--- libc/config/linux/x86_64/entrypoints.txt
+++ libc/config/linux/x86_64/entrypoints.txt
@@ -313,7 +313,7 @@
 if(LLVM_LIBC_FULL_BUILD)
   list(APPEND TARGET_LIBC_ENTRYPOINTS
     # assert.h entrypoints
-    # libc.src.assert.__assert_fail
+    libc.src.assert.__assert_fail
 
     # dirent.h entrypoints
     libc.src.dirent.closedir


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138056.475552.patch
Type: text/x-patch
Size: 1767 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20221115/2b252174/attachment.bin>