[libc-commits] [PATCH] D138040: [libc] Fix tablegen when using a runtimes build

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/CMakeLists.txt:17
 
+# For a runtimes build we need to manually include tablgen and LLVM directories.
+if ("libc" IN_LIST LLVM_ENABLE_RUNTIMES)
----------------
IIRC, the only dependency we have outside of the `libc` directory is for tablegen. So, could we perhaps move this logic over to something more local to the places where tablegen is used? Also, we want to move away from using the `LLVM_` prefix to libc's CMake variables - just use `LIBC_` for the prefix. In this case, it can be more specific like `LIBC_TABLEGEN_INCLUDE_DIRS`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138040/new/

https://reviews.llvm.org/D138040