[libc-commits] [PATCH] D137867: [libc] move fork into threads folder

[Tue Ly via Phabricator via libc-commits]

lntue added a comment.

In D137867#3926145 <https://reviews.llvm.org/D137867#3926145>, @sivachandra wrote:

> In D137867#3926026 <https://reviews.llvm.org/D137867#3926026>, @michaelrj wrote:
>
>> I meant that the `fork_callbacks` utility should be moved into the `threads` folder since it depends on the other utilities in the `threads` folder and is only used by the `pthreads` utilities. I think having `file` be separate makes sense because that's a category that is more specific than threads. The goal is to group similar things so that they can be found, and while I would expect fork related utilities to be in a threads folder, I wouldn't expect file related utilities to be in a threads folder.
>
> I still don't understand - perhaps you are thinking `fork` is related to threads? Also, can you explain what prompted this change? Was something failing on arm32?

It was actually blocking macos builds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137867/new/

https://reviews.llvm.org/D137867