[libc-commits] [PATCH] D137871: [libc][math] Improve the performance and error printing of UInt.

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/src/__support/UInt.h:24
 
-template <size_t Bits> class UInt {
+template <size_t Bits> struct UInt {
 
----------------
is there a reason this is changed?


================
Comment at: libc/src/__support/UInt.h:313
+      size_t j = WordCount - 1 - drop;
+      for (; j; --i, --j) {
+        val[i] = (val[j] << shift) | (val[j - 1] >> (64 - shift));
----------------
for clarity could this be `j > 0`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137871/new/

https://reviews.llvm.org/D137871