[libc-commits] [PATCH] D137867: [libc] move fork into threads folder

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

I did not go into the specifics of this patch (I am on vacation) but I have concern about it because of the subject:

  Fork, as a thread function, should go in the threads folder.
  Additionally, it depends on the thread mutex, and it was causing build
  issues for targets where we don't support threads.

Two things:

1. Why is `fork` a thread function?
2. If the logic of "it depends on the thread mutex" is applied to other parts of the libc (for example `File`), they all should be moved into the `threads` directory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137867/new/

https://reviews.llvm.org/D137867