[libc-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

Francesco Petrogalli via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Nov 11 09:36:52 PST 2022


fpetrogalli added a comment.

Hi @lenary  - thank you for working on this!

The patch is reasonable to me.

I agree on the suggestion of using forwarding headers or the first iteration of the change, it will make it easier to review.

I'll adapt the auto-get patch at D137517 <https://reviews.llvm.org/D137517> on D137838 <https://reviews.llvm.org/D137838>.

As for the name `TargetParser`. @arsenm came up with the name `SubtargetRegistry`. I am fine with either names.

Francesco


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137838/new/

https://reviews.llvm.org/D137838



More information about the libc-commits mailing list