[libc-commits] [PATCH] D137453: [libc] Add add_with_carry to builtin wrapper.
Tue Ly via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Nov 4 13:35:18 PDT 2022
lntue added inline comments.
================
Comment at: libc/src/__support/builtin_wrappers.h:72
+inline constexpr cpp::enable_if_t<
+ cpp::is_integral_v<T> && cpp::is_unsigned_v<T>, T>
+add_with_carry(T a, T b, T carry_in, T &carry_out) {
----------------
orex wrote:
> Thank you. Font you think, that you should put `::value` everywhere here? I'm not so familiar with internal classes...
Since C++17, `_t` and `_v` helpers were added to C++, and some of our internal `cpp::` templates did follow.
https://en.cppreference.com/w/cpp/types/is_integral
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137453/new/
https://reviews.llvm.org/D137453
More information about the libc-commits
mailing list