[libc-commits] [PATCH] D137338: Fix dupe word typos

[Aaron Ballman via Phabricator via libc-commits]

aaron.ballman added a comment.

The clang parts generally LG, but I spotted a few things. Thank you for this cleanup effort!



================
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:467
 
-  /// Return a matcher that that points to the same implementation, but sets the
+  /// Return a matcher that points to the same implementation, but sets the
   ///   traversal kind.
----------------
This is a good change, but you also need to run `clang/docs/tools/dump_ast_matchers.py` to regenerate the public-facing documentation that is generated from this file.


================
Comment at: clang/lib/CodeGen/CodeGenTBAA.cpp:341
     if (const CXXRecordDecl *CXXRD = dyn_cast<CXXRecordDecl>(RD)) {
-      // Handle C++ base classes. Non-virtual bases can treated a a kind of
+      // Handle C++ base classes. Non-virtual bases can treated a kind of
       // field. Virtual bases are more complex and omitted, but avoid an
----------------
I think this should read:
```
 // Handle C++ base classes. Non-virtual bases can treated as a kind of
```


================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:47
   // complete architecture list, nor a reasonable subset. The problem is that
-  // historically the driver driver accepts this and also ties its -march=
   // handling to the architecture name, so we need to be careful before removing
----------------
This is duplicated just often enough and in just enough contexts where I think "driver driver" means "the driver that drives another driver", but it'd be nice if someone else could confirm or deny that.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:87
 
-  // If using a driver driver, force the arch.
   if (getToolChain().getTriple().isOSDarwin()) {
----------------
Same for this one as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137338/new/

https://reviews.llvm.org/D137338