[libc-commits] [PATCH] D136960: [libc] Add a porting guide to the docs.

[Jeff Bailey via Phabricator via libc-commits]

jeffbailey added inline comments.


================
Comment at: libc/docs/porting.rst:21
+
+.. note:: Windows development is not as active as the development on Linux.
+   There is a
----------------
Is it worth a note about Fuchsia?  It's mentioned occasionally, and might be worth one here that just notes that because they build it as part of their OS, they're choosing out-of-tree development.


================
Comment at: libc/docs/porting.rst:30
+If the :ref:`fullbuild_mode` is to be supported on the new operating system,
+then a file named ``api.td`` should be added in it's the config directory. It
+is written in the
----------------
its.  "it's" is always an abbreviation for "it is"


================
Comment at: libc/docs/porting.rst:30
+If the :ref:`fullbuild_mode` is to be supported on the new operating system,
+then a file named ``api.td`` should be added in it's the config directory. It
+is written in the
----------------
jeffbailey wrote:
> its.  "it's" is always an abbreviation for "it is"
s,the,,


================
Comment at: libc/docs/porting.rst:39-40
+.. note:: In future, LLVM tablegen will be replaced with a different DSL to list
+   config information. So, the use of the ``api.td`` might be replaced with a
+   different methodology.
+
----------------
This sentence is redundant.


================
Comment at: libc/docs/porting.rst:103
+
+CI builders
+===========
----------------
I would be inclined to bump this to the top of the page.  No matter how enthusiastic a person is to do the porting work, we simply don't want the patches unless we know there's a CI available to test it pretty much right away.

Engineering before coding =)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136960/new/

https://reviews.llvm.org/D136960