[libc-commits] [PATCH] D137147: [libc] Add x86_64 implementation of setjmp and longjmp.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/src/setjmp/longjmp.cpp:17
+
+LLVM_LIBC_FUNCTION(void, longjmp, (__jmp_buf * buf, int val)) {
+#ifdef LLVM_LIBC_ARCH_X86_64
----------------
michaelrj wrote:
> this function should be marked `noreturn`
As far as the compiler frontend is concerned, it does not know that this function is actually `noreturn`. So, putting the `noreturn` attribute actually generates an error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137147/new/

https://reviews.llvm.org/D137147