[libc-commits] [PATCH] D125939: [libc] add fprintf and file_writer
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Thu May 19 09:38:23 PDT 2022
sivachandra added inline comments.
Comment at: libc/src/stdio/printf_core/file_writer.h:23
+ __llvm_libc::File *file = reinterpret_cast<__llvm_libc::File *>(raw_pointer);
+ file->write(to_write, len);
Is it OK to ignore the return value? For example, if `file` were read only, then `write` would fail. Shouldn't that be reflected in the `fprintf` return value?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits