[libc-commits] [PATCH] D125327: [libc] add printf converter

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/src/stdio/printf_core/converter.h:24
 public:
-  Converter(Writer *writer);
+  Converter(Writer *init_writer) : writer(init_writer) {}
 
----------------
sivachandra wrote:
> Will we see more state added in future to keep `Converter` a class?
no, it was mostly a class because the other two pieces are. Now that you've pointed it out it seems obvious to just pass the writer to the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125327/new/

https://reviews.llvm.org/D125327