[libc-commits] [PATCH] D125327: [libc] add printf converter

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/stdio/printf_core/char_converter.h:14
+namespace printf_core {
+void convert_char(Writer *writer, FormatSection to_conv) {
+  char c = to_conv.conv_val_raw;
----------------
Nit: Empty line before this.


================
Comment at: libc/src/stdio/printf_core/char_converter.h:29
+  }
+}
+} // namespace printf_core
----------------
Empty line after. Same in other files also.


================
Comment at: libc/src/stdio/printf_core/converter.h:24
 public:
-  Converter(Writer *writer);
+  Converter(Writer *init_writer) : writer(init_writer) {}
 
----------------
Will we see more state added in future to keep `Converter` a class?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125327/new/

https://reviews.llvm.org/D125327