[libc-commits] [PATCH] D125055: [libc] Add LINK_LIBRARIES option to add_fp_unittest and add_libc_unittest.
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri May 6 10:08:46 PDT 2022
sivachandra added inline comments.
================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:149
- target_link_libraries(${fq_target_name} PRIVATE ${link_object_files})
- if(LIBC_UNITTEST_LINK_OPTIONS)
- target_link_options(
- ${fq_target_name}
- PRIVATE ${LIBC_UNITTEST_LINK_OPTIONS}
- )
- endif()
+ list(PREPEND LIBC_UNITTEST_LINK_LIBRARIES ${link_object_files})
----------------
Add a comment explaining why its a `PREPEND` here and an `APPEND` down below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125055/new/
https://reviews.llvm.org/D125055
More information about the libc-commits
mailing list