[libc-commits] [PATCH] D124959: [libc] add uint128 implementation

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri May 6 01:30:17 PDT 2022


sivachandra added a comment.

We already have a more generic `UInt` class here: https://github.com/llvm/llvm-project/blob/main/libc/src/__support/FPUtil/UInt.h

It does not have all the operations exactly as you want, but I could add straightforward extensions and the tests you have in this patch all pass. I strongly suggest adding such extensions to the existing class instead of re-implementing a new class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124959/new/

https://reviews.llvm.org/D124959



More information about the libc-commits mailing list