[libc-commits] [PATCH] D122392: [NFC][libc] Find the benchmark package and adjust the dependency targets

Guoxiong Li via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Mar 25 05:37:28 PDT 2022


lgxbslgx added a comment.

When I removed the `build` directory to clean the cache and then rebuilt the project by using my patch, I got the error which is same as the `premerge checks` in the build bot.
Apologize for the confusedly previous information.

Conclusively, currently, the main branch and my patch can't be built successfully locally.
When using the main branch, it reports : `The target "benchmark" does not exist.`   like the issue-53686
When using my patch, it reports: `Could not find a package configuration file provided by "benchmark"`  like the `premerge checks`

When I try the following configuration, I get the error message like https://discourse.llvm.org/t/error-when-building-llvm-libc-with-gcc/4166.(Another error which is unrelated to this issue)
It seems that the package benchmark and the targets were found, which means the issue-53686 can be solved by the following configuration.
Could I get your help to try it in your environment to verify it? Thanks a lot.

  find_package(benchmark REQUIRED PATHS ${CMAKE_CURRENT_SOURCE_DIR}/../../build/third-party/benchmark)
  add_dependencies(libc-benchmark benchmark::benchmark)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122392/new/

https://reviews.llvm.org/D122392



More information about the libc-commits mailing list