[libc-commits] [PATCH] D121564: [libc] Let exhaustive tests indicate each interval PASSED/FAILED.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Mar 16 00:52:50 PDT 2022


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/utils/UnitTest/LibcTest.h:404
       return;                                                                  \
   } while (0)
 
----------------
lntue wrote:
> sivachandra wrote:
> > To math the pattern of other `ASSERT_<>` macros, can we construct `ASSERT_THAT` using `EXPECT_THAT`?
> Look like we need to have another patch to wrap other ASSERT_<> in `do { ... } while (0)` to make it not stealing `else` clause if being used inside other `if` statement.
They are not compound statements so shouldn't require a `do {...} while (0)` treatment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121564/new/

https://reviews.llvm.org/D121564



More information about the libc-commits mailing list