[libc-commits] [PATCH] D121676: [libc] Add implementation of POSIX lseek function.

[Tue Ly via Phabricator via libc-commits]

lntue accepted this revision.
lntue added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/include/llvm-libc-macros/file-seek-macros.h:9
 
 #ifndef __LLVM_LIBC_MACROS_STDIO_MACROS_H
 #define __LLVM_LIBC_MACROS_STDIO_MACROS_H
----------------
I think you should change the header guard to match the file name.


================
Comment at: libc/test/src/unistd/lseek_test.cpp:1
+//===-- Unittests for read and write --------------------------------------===//
+//
----------------
*lseek


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121676/new/

https://reviews.llvm.org/D121676