[libc-commits] [PATCH] D121564: [libc] Let exhaustive tests indicate each interval PASSED/FAILED.
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Sun Mar 13 23:14:14 PDT 2022
sivachandra added inline comments.
================
Comment at: libc/test/src/math/exhaustive/exhaustive_test.h:26
+ virtual void check(T start, T stop, mpfr::RoundingMode rounding,
+ bool &result) = 0;
};
----------------
Since its a bool value, would it better as a return value instead of reference argument?
================
Comment at: libc/test/src/math/exhaustive/expf_test.cpp:31
} while (bits++ < stop);
+ result = true;
}
----------------
If you use `EXPECT_<...>` macro as opposed to `ASSERT_<...>` macro, wouldn't `result` always get set to `true`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121564/new/
https://reviews.llvm.org/D121564
More information about the libc-commits
mailing list