[libc-commits] [PATCH] D120914: [libc] Initial support for darwin-aarch64.

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/test/src/stdlib/strtold_test.cpp:178
            (__uint128_t(0x7ffe800000) << 40),
-           (__uint128_t(0x7ffe000000000000) << 64));
+           (__uint128_t(0x7ffe000000000000) << 64), ERANGE);
   run_test("0x123456789abcdef", 17, 0x43723456789abcdf,
----------------
lntue wrote:
> sivachandra wrote:
> > Why are the changes in this file required?
> These are corresponding outputs and errno's if the output type is double precision.  I guess we just haven't tested these when long double is double yet.
Tue is correct, I didn't have a long double is double system to test with when I was originally writing these tests. His changes are correct, as checked by calling `strtod` on those inputs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120914/new/

https://reviews.llvm.org/D120914