[libc-commits] [libc] e1dcda9 - [libc][NFC] remove completed TODOs

[Michael Jones via libc-commits]

Author: Michael Jones
Date: 2022-03-08T11:58:14-08:00
New Revision: e1dcda966edf6acf4fe564975f3922781da52529

URL: https://github.com/llvm/llvm-project/commit/e1dcda966edf6acf4fe564975f3922781da52529
DIFF: https://github.com/llvm/llvm-project/commit/e1dcda966edf6acf4fe564975f3922781da52529.diff

LOG: [libc][NFC] remove completed TODOs

There were some "TODO" messages that were for things that I have already
completed. This patch removes those.

Reviewed By: michaelrj

Differential Revision: https://reviews.llvm.org/D121232

Added: 
    

Modified: 
    libc/src/__support/str_to_float.h
    libc/test/src/__support/str_to_float_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/src/__support/str_to_float.h b/libc/src/__support/str_to_float.h
index 8defeed122a9f..f7cb2a623b368 100644
--- a/libc/src/__support/str_to_float.h
+++ b/libc/src/__support/str_to_float.h
@@ -21,8 +21,6 @@ namespace __llvm_libc {
 namespace internal {
 
 template <class T> uint32_t inline leading_zeroes(T inputNumber) {
-  // TODO(michaelrj): investigate the portability of using something like
-  // __builtin_clz for specific types.
   constexpr uint32_t BITS_IN_T = sizeof(T) * 8;
   if (inputNumber == 0) {
     return BITS_IN_T;

diff  --git a/libc/test/src/__support/str_to_float_test.cpp b/libc/test/src/__support/str_to_float_test.cpp
index fa2efda422019..dc70ebc1571d4 100644
--- a/libc/test/src/__support/str_to_float_test.cpp
+++ b/libc/test/src/__support/str_to_float_test.cpp
@@ -259,18 +259,6 @@ TEST(LlvmLibcStrToFloatTest, SimpleDecimalConversionExtraTypes) {
   EXPECT_EQ(double_output_mantissa, uint64_t(0x1AC53A7E04BCDA));
   EXPECT_EQ(output_exp2, uint32_t(1089));
   EXPECT_EQ(errno, 0);
-
-  // TODO(michaelrj): Get long double support working.
-
-  // __uint128_t longDoubleOutputMantissa = 0;
-  // outputExp2 = 0;
-
-  // errno = 0;
-  // __llvm_libc::internal::simple_decimal_conversion<long double>(
-  //     "123456789012345678900", &longDoubleOutputMantissa, &outputExp2);
-  // EXPECT_EQ(longDoubleOutputMantissa, __uint128_t(0x1AC53A7E04BCDA));
-  // EXPECT_EQ(outputExp2, uint32_t(1089));
-  // EXPECT_EQ(errno, 0);
 }
 
 #if defined(LONG_DOUBLE_IS_DOUBLE)