[libc-commits] [PATCH] D121232: [libc][NFC] remove completed TODOs

[Michael Jones via Phabricator via libc-commits]

michaelrj created this revision.
michaelrj added reviewers: lntue, sivachandra.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
michaelrj requested review of this revision.

There were some "TODO" messages that were for things that I have already
completed. This patch removes those.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121232

Files:
  libc/src/__support/str_to_float.h
  libc/test/src/__support/str_to_float_test.cpp


Index: libc/test/src/__support/str_to_float_test.cpp
===================================================================
--- libc/test/src/__support/str_to_float_test.cpp
+++ libc/test/src/__support/str_to_float_test.cpp
@@ -259,18 +259,6 @@
   EXPECT_EQ(double_output_mantissa, uint64_t(0x1AC53A7E04BCDA));
   EXPECT_EQ(output_exp2, uint32_t(1089));
   EXPECT_EQ(errno, 0);
-
-  // TODO(michaelrj): Get long double support working.
-
-  // __uint128_t longDoubleOutputMantissa = 0;
-  // outputExp2 = 0;
-
-  // errno = 0;
-  // __llvm_libc::internal::simple_decimal_conversion<long double>(
-  //     "123456789012345678900", &longDoubleOutputMantissa, &outputExp2);
-  // EXPECT_EQ(longDoubleOutputMantissa, __uint128_t(0x1AC53A7E04BCDA));
-  // EXPECT_EQ(outputExp2, uint32_t(1089));
-  // EXPECT_EQ(errno, 0);
 }
 
 #if defined(LONG_DOUBLE_IS_DOUBLE)
Index: libc/src/__support/str_to_float.h
===================================================================
--- libc/src/__support/str_to_float.h
+++ libc/src/__support/str_to_float.h
@@ -21,8 +21,6 @@
 namespace internal {
 
 template <class T> uint32_t inline leading_zeroes(T inputNumber) {
-  // TODO(michaelrj): investigate the portability of using something like
-  // __builtin_clz for specific types.
   constexpr uint32_t BITS_IN_T = sizeof(T) * 8;
   if (inputNumber == 0) {
     return BITS_IN_T;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121232.413864.patch
Type: text/x-patch
Size: 1365 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20220308/7a685ad8/attachment.bin>